Allow to override fee rates for onchain payments#434
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Jan 27, 2025
Merged
Allow to override fee rates for onchain payments#434tnull merged 1 commit intolightningdevkit:mainfrom
tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
tnull
force-pushed
the
2025-01-allow-to-override-feerate
branch
from
c4afd11 to
ec6bf80
Compare
jkczyz
reviewed
Jan 22, 2025
tnull
force-pushed
the
2025-01-allow-to-override-feerate
branch
3 times, most recently
from
1b0621d to
bfbc72d
Compare
We allow to override our fee estimator in the `send_to_address` and `send_all_to_address` API methods. To this end, we implement a bindings-compatible wrapper around `bitcoin::FeeRate`.
tnull
force-pushed
the
2025-01-allow-to-override-feerate
branch
from
bfbc72d to
d6672b6
Compare
Collaborator
Author
|
Squashed fixups without further changes. |
jkczyz
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176.
We allow to override our fee estimator in the
send_to_addressandsend_all_to_addressAPI methods. To this end, we implement a bindings-compatible wrapper aroundbitcoin::FeeRate.